pass-through for Schema-based results #1497
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the response-parameter is filled and the result is already a Schema we don't need to verify it again.
Brief reasoning for the situation:
Wagtail has a [new guide how to integrate Ninja](based on https://docs.wagtail.org/en/v7.0/advanced_topics/api/django-ninja.html).
In it they use this
This works but has its issues since basically the returned Page type (the django Model) is tried to be fitted against all different
response
-Schemata. Obviously that's a performance issue but it brings other problems too, which I dont want to go too deep into.So my solution would be:
this does currently not work, because the result is being re-parsed, because I have
response
set in the decorator. Obviously I could remove that but then I'd lose the types.This PR allows Schemas to be directly returned, assuming that the validation already has happened.
Thanks so much