Skip to content

Conversation

@boris-petrov
Copy link
Contributor

This is the only plugin that I use that still uses ember-cli-babel 6 so I decided to update it. Not sure if this is enough or more changes are needed to the plugin?

cc @vitch

@vitch
Copy link
Owner

vitch commented Mar 4, 2021

Honestly I haven't used this plugin in many years. If you are using it and it still works for you with this change I'm happy to merge and release...

@vitch
Copy link
Owner

vitch commented Mar 4, 2021

Although it looks like Travis is unhappy because:

The command "eval yarn --frozen-lockfile " failed.

@boris-petrov
Copy link
Contributor Author

I was just trying to figure that out. Any ideas what that is and why it fails?

@vitch
Copy link
Owner

vitch commented Mar 4, 2021

Actually - I think the real error is:

The engine "node" is incompatible with this module. Expected version "8.* || 10.* || >= 12.*"

I set my node and yarn versions to the same as TravisCI via volta (6.17.1 and 1.3.2 respectively) and got the same error.

Maybe you can update node_js: in the travis.yml too?

@boris-petrov
Copy link
Contributor Author

Done. But this means a new major version. And while we're at it, we could do other version updates I guess?

@boris-petrov boris-petrov force-pushed the update-ember-cli-babel branch from 0381c4d to 9046f48 Compare May 31, 2021 18:09
@boris-petrov boris-petrov force-pushed the update-ember-cli-babel branch from 9046f48 to 124bb20 Compare May 31, 2021 18:14
@boris-petrov
Copy link
Contributor Author

@vitch - this is ready for merging. I moved a few things around and updated the used webfonts-generator library. The Node requirement had to be updated to version 12 because of ttf2woff2 - here is a failing Travis build for proof.

I tried out the branch, it seems to work great. So a new (major) release will be appreciated! :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants