-
Notifications
You must be signed in to change notification settings - Fork 11
feat: support async act v2 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…vitest-browser-react # Conflicts: # package.json # pnpm-lock.yaml # src/pure.tsx # test/render.test.tsx
@sheremet-va let me know if theres any additional work or changes needed to move this forward. I think theres also a way to implement this as a backwards compatible change by returning thenables instead of promises. But not sure its worth it as it would make the API and implementation more complicated |
Can you also prepare PRs updating vitest docs and vitest-browser-examples when this is released? |
Sure happy to do that. Should hopefully have some time free next week |
👋🏼 we're quite keen to use this over at sanity is there a chance to get an experimental release in the meantime that we could test out? we use a lot of suspended components on our dashboard project. |
This sounds good to me. We probably can't release the v2 version fully because |
FYI i've just added this to an internal project & the test that was failing now works as expected. I had some issues (that weren't there before) where i needed to await MSW's I'll open issues for anything I do find though. Thanks again for the beta 👍🏼 |
made some minor updates to the PR #10
fixes #9