Do not panic if the pod details are not found #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chauhanshubham
force-pushed
the
event-framework-pod-events
branch
from
e27c664 to
57e3c33
Compare
hemantavi
previously approved these changes
Nov 16, 2021
hemantavi
reviewed
Nov 16, 2021
gslb/ingestion/gslb.go
Outdated
| gslbutils.LogAndPanic("error getting AMKO pod details: " + err.Error()) | ||
| gslbutils.Warnf("Error getting AMKO pod details, %s.", err.Error()) | ||
| } | ||
| amkoControlConfig.SaveAMKOPodObjectMeta(pod.DeepCopy()) |
Contributor
There was a problem hiding this comment.
If we don't panic in 680, won't we crash here? Assuming pod is nil, pod.DeepCopy() will cause a runtime panic?
Contributor
Author
There was a problem hiding this comment.
you're right, fixed. thanks
chauhanshubham
force-pushed
the
event-framework-pod-events
branch
from
57e3c33 to
e6377b4
Compare
Contributor
Author
|
build amko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.