Retry support for ingestion layer #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes AV-113235 Currently, if AMKO is unable to reach the controller because of a network issue while validating the references in a `GSLBHostRule`, it doesn't retry or reconcile even after the network issue is fixed. A reconcilation may also be required if the user provides a non-existent reference, but the user creates the reference later. This PR introduces a retry queue for the ingestion layer. Currently, it will only be used for `GSLBHostRule` objects. It functions like the slow retry queue, but at the end of the tiner expiry, it makes a decision to call add/update the `GSLBHostRule` based on the key that's pushed. Decision to retry: A retry decision is made for all cases for an object reference check, except for non-federated objects.
hemantavi
requested review from
RiyaGaniga-avi,
chauhanshubham,
monotosh-avi and
sudswasavi
monotosh-avi
reviewed
Jun 1, 2021
| if fullSync && isHealthMonitorRefPresentInCache(refName) { | ||
| gslbutils.Debugf("health monitor %s present in hm cache", refName) | ||
| return true | ||
| return nil |
Contributor
There was a problem hiding this comment.
Is it possible that the ref is removed from the controller but present in cache ?
| case gslbutils.GslbHostRuleType: | ||
| ghrObj, err := getGslbHostRule(ns, name) | ||
| if err != nil { | ||
| gslbutils.Errf("key: %s, msg: error in getting GSLBHostRule object: %v", key, err) |
Contributor
There was a problem hiding this comment.
Should we return error in case of delete too ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AV-113235
Currently, if AMKO is unable to reach the controller because of a network
issue while validating the references in a
GSLBHostRule, it doesn'tretry or reconcile even after the network issue is fixed. A reconcilation
may also be required if the user provides a non-existent reference, but
the user creates the reference later.
This PR introduces a retry queue for the ingestion layer. Currently, it
will only be used for
GSLBHostRuleobjects. It functions like the slowretry queue, but at the end of the tiner expiry, it makes a decision
to call add/update the
GSLBHostRulebased on the key that's pushed.Decision to retry: A retry decision is made for all cases for an object
reference check, except for non-federated objects.