Skip to content

Windows: Fix pe_symbols type checking #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Windows: Fix pe_symbols type checking #1849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions volatility3/framework/plugins/windows/pe_symbols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,17 +709,15 @@ def _validate_wanted_modules(

# symbol_info will be a symbol name or address requested
for symbol_info in wanted_symbols:
if (
wanted_type == wanted_names_identifier
and type(symbol_info) not in valid_name_types
if wanted_type == wanted_names_identifier and not isinstance(
symbol_info, tuple(valid_name_types)
):
raise ValueError(
f"The requested symbol name has a type of {type(symbol_info)} which is not in the allowed set of {valid_name_types}"
)

elif (
wanted_type == wanted_addresses_identifier
and type(symbol_info) not in valid_address_types
elif wanted_type == wanted_addresses_identifier and not isinstance(
symbol_info, tuple(valid_address_types)
):
raise ValueError(
f"The requested address has a type of {type(symbol_info)} which is not in the allowed set of {valid_address_types}"
Expand Down
Loading