Skip to content

catch errors based on missing authentication to allow creation of admin user on replicaset setup #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

catch errors based on missing authentication to allow creation of admin user on replicaset setup #479

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3355a7d
catch errors based on missing authentication to allow creation of adm…
Aug 8, 2018
a0dd29f
remove obsolete logging messages
Aug 13, 2018
6ae5051
Add logging and fix style offenses
Aug 13, 2018
3fcdfde
fix style offenses
Aug 13, 2018
c3d7b15
avoid nil exception for res
Aug 14, 2018
4e897bc
fix style issues
Aug 14, 2018
e4d9b68
rescue StandardError and write variable to print an error message
Aug 14, 2018
d8af457
fix if query + logging
Aug 14, 2018
6924c35
do not retry command without mongorc_file
Aug 27, 2018
38a83c4
removed double white spaces
Aug 27, 2018
3d08ff2
remove obsolete indent
Sep 14, 2018
f752b12
fix rubocop issue
Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/puppet/provider/mongodb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,14 @@ def self.conn_string

def self.db_ismaster
cmd_ismaster = 'db.isMaster().ismaster'
cmd_ismaster = mongorc_file + cmd_ismaster if mongorc_file
db = 'admin'
res = mongo_cmd(db, conn_string, cmd_ismaster).to_s.chomp

if mongorc_file
res = mongo_cmd(db, conn_string, mongorc_file + cmd_ismaster).to_s.chomp
end
if res.match(/Authentication failed/) or not mongorc_file
Copy link
Member

@ekohl ekohl Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you should switch these around because res will not be defined if mongorc_file is false.

res = mongo_cmd(db, conn_string, cmd_ismaster).to_s.chomp
end
res.eql?('true') ? true : false
end

Expand Down
14 changes: 9 additions & 5 deletions lib/puppet/provider/mongodb_database/mongodb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,23 @@

def self.instances
require 'json'
dbs = JSON.parse mongo_eval('printjson(db.getMongo().getDBs())')
begin
Copy link
Member

@ekohl ekohl Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this indenting. You can write

def self.instances
  # code
rescue
  # code
end

dbs = JSON.parse mongo_eval('printjson(db.getMongo().getDBs())')

dbs['databases'].map do |db|
new(name: db['name'],
ensure: :present)
dbs['databases'].map do |db|
new(name: db['name'],
ensure: :present)
end
rescue
Copy link
Member

@ekohl ekohl Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log anything about why it failed? Otherwise debugging might be very hard.

{}
Copy link
Member

@ekohl ekohl Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a list?

end
end

# Assign prefetched dbs based on name.
def self.prefetch(resources)
dbs = instances
resources.keys.each do |name|
provider = dbs.find { |db| db.name == name }
provider = dbs.find {|db| db.name == name}
resources[name].provider = provider if provider
end
end
Expand Down
36 changes: 20 additions & 16 deletions lib/puppet/provider/mongodb_user/mongodb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,20 @@ def self.instances
end
return allusers
else
users = JSON.parse mongo_eval('printjson(db.system.users.find().toArray())')

users.map do |user|
new(name: user['_id'],
ensure: :present,
username: user['user'],
database: user['db'],
roles: from_roles(user['roles'], user['db']),
password_hash: user['credentials']['MONGODB-CR'],
scram_credentials: user['credentials']['SCRAM-SHA-1'])
begin
users = JSON.parse mongo_eval('printjson(db.system.users.find().toArray())')

users.map do |user|
new(name: user['_id'],
ensure: :present,
username: user['user'],
database: user['db'],
roles: from_roles(user['roles'], user['db']),
password_hash: user['credentials']['MONGODB-CR'],
scram_credentials: user['credentials']['SCRAM-SHA-1'])
end
rescue
{}
end
end
else
Expand All @@ -49,7 +53,7 @@ def self.instances
def self.prefetch(resources)
users = instances
resources.each do |name, resource|
provider = users.find { |user| user.username == (resource[:username]) && user.database == (resource[:database]) }
provider = users.find {|user| user.username == (resource[:username]) && user.database == (resource[:database])}
resources[name].provider = provider if provider
end
end
Expand All @@ -63,9 +67,9 @@ def create
raise Puppet::Error, "password_hash can't be set on MongoDB older than 3.0; use password instead"
end
user = {
user: @resource[:username],
pwd: @resource[:password],
roles: @resource[:roles]
user: @resource[:username],
pwd: @resource[:password],
roles: @resource[:roles]
}

mongo_eval("db.addUser(#{user.to_json})", @resource[:database])
Expand All @@ -84,7 +88,7 @@ def create
"roles": #{@resource[:roles].to_json},
"digestPassword": false
}
EOS
EOS

mongo_eval("db.runCommand(#{cmd_json})", @resource[:database])
end
Expand Down Expand Up @@ -155,7 +159,7 @@ def roles=(roles)
else
grant = roles - @property_hash[:roles]
unless grant.empty?
mongo_eval("db.getSiblingDB('#{@resource[:database]}').grantRolesToUser('#{@resource[:username]}', #{grant. to_json})")
mongo_eval("db.getSiblingDB('#{@resource[:database]}').grantRolesToUser('#{@resource[:username]}', #{grant.to_json})")
end

revoke = @property_hash[:roles] - roles
Expand Down