Extend shader compiler define syntax to allow name=value instead of just valueless defines #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust valueless defines
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supports issue 1534 in VulkanSceneGraph and is a companion with VulkanSceneGraph Pull Request 1539.
The change is to the vsgclip example. It adds a command line option
-nwhich takes an integer of either 1 or 2 indicating how many clips are desired. If not specified 1 is the default and the example behaves the same as before, clipping using a sphere in eye coordinates. If you specify 2 the example adds another clip on the X plane in world coordinates at X=0. The gl_ClipDistance array is dimensioned by the shader compiler define.