Finish Adw/GTK 4 override, and test them #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a handful of unit tests to ensure that the GTK 4 and Adwaita overrides don't break.
This means dropping the tests for GTK 3, therefore regressions will no longer be caught immediately. The reason for this is that multiple versions of the same library cannot be loaded at once. While it is possible to maintain the old tests by running them in a separate test runner, I have no interest in doing so. LuaGObject's first release is already half a decade after GTK 4 launched, and a user using this new project to write a GUI app really ought to only use the latest GTK. That said, the old GTK 3 overrides continue to be preserved.