feat(core): update recorder #1330
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| const timeRemaining = checkIntervalMs - (now - startTime); | ||
| const sleepTask = await this.taskForSleep(timeRemaining, modelConfig); | ||
| await taskExecutor.append(sleepTask); | ||
| } |
There was a problem hiding this comment.
When a waitFor query task fails (e.g. the AI extractor throws on malformed data), taskExecutor.flush() leaves the executor in the error state but the new loop continues and immediately calls taskExecutor.append again for the sleep task. Because append asserts that the executor is not in error, this raises "executor is in error state, cannot append task" instead of returning the executor with the original error information, reintroducing the bug the deleted regression test covered. A failing waitFor now aborts with an assertion instead of surfacing the AI error in the result, so any scenario where the first waitFor iteration errors will crash the call.
Useful? React with 👍 / 👎.
2 participants
No description provided.