Skip to content

test(e2e): playwright support lazyCompilation after Rsbuild 1.4.0, remove RSPRESS_LAZY_COMPILATION=false #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −3
Open

test(e2e): playwright support lazyCompilation after Rsbuild 1.4.0, remove RSPRESS_LAZY_COMPILATION=false #2319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions e2e/utils/runCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ export async function runDevCommand(
appDir,
env: {
PORT: port.toString(),
// This is an escape hatch for playwright test, playwright does not support lazyCompilation
RSPRESS_LAZY_COMPILATION: 'false',
},
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/node/initRsbuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ async function createInternalBuildConfig(
...(base.length > 0 ? { base: removeTrailingSlash(base) } : {}),
},
dev: {
lazyCompilation: process.env.RSPRESS_LAZY_COMPILATION !== 'false', // This is an escape hatch for playwright test, playwright does not support lazyCompilation
lazyCompilation: process.env.RSPRESS_LAZY_COMPILATION !== 'false', // This is an escape hatch
// Serve static files
setupMiddlewares: middlewares => {
middlewares.unshift(serveSearchIndexMiddleware(config));
Expand Down
Loading