[BUGFIX] Mitigate splitted DataHandler hook method of EXT:container
#467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `b13/container` extension (`EXT:container` ) implements a custom DataHandler hook to process data in the required manner and recently splitted the method `localizeOrCopyToLanguage()` into two dedicated methods for the `CommandMapPostProcessingHook` [2] to fix an issue [1]. `EXT:deepltranslate_core` needs to override that hook in case that extension is installed to ensure both extension to work and broke due to that change. This change mitigates this by verify the existance of the methods now and call the existing once and throws an exception if if will be renamed again in the future. [1] b13/container#609 [2] b13/container#617
calien666
approved these changes
Jun 2, 2025
Member
Author
|
Fix or #471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
b13/containerextension (EXT:container) implements a customDataHandler hook to process data in the required manner and recently
splitted the method
localizeOrCopyToLanguage()into two dedicatedmethods for the
CommandMapPostProcessingHook[2] to fix an issue [1].EXT:deepltranslate_coreneeds to override that hook in case thatextension is installed to ensure both extension to work and broke
due to that change.
This change mitigates this by verify the existance of the methods
now and call the existing once and throws an exception if if will
be renamed again in the future.
[1] b13/container#609
[2] b13/container#617