Add recalulateCameraLens method to ARToolKitNFT class #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented recalulateCameraLens method in ARToolKitNFT to update camera lens parameters based on the current near and far planes. - Added method declaration in ARToolKitNFT_js.h and ARToolKitNFT_js_td.h. - Exposed recalulateCameraLens method in Emscripten bindings for JavaScript access. - Ensured consistency of the method implementation across ARToolKitNFT_js.cpp and ARToolKitNFT_js_td.cpp.
- Introduced a new function `recalculateCameraLens` in ARToolKitJS and ARToolKitJS_td to update the camera lens parameters based on the current settings. - Corrected the spelling of `recalulateCameraLens` to `recalculateCameraLens` in ARToolKitNFT_js and ARToolKitNFT_js_td classes and their respective bindings. - Updated the Emscripten bindings to expose the new `recalculateCameraLens` function for JavaScript usage.
…a updates - Introduced recalculateCameraLens method in both ARControllerNFT and its ES6 variant. - This method allows recalculating the camera lens based on current camera parameters, ensuring accurate rendering when parameters change.
kalwalt
force-pushed
the
feature-recalculate-camera
branch
from
e7acfed to
3e4f1c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new method,
recalulateCameraLens, to theARToolKitNFTclass and integrates it into the codebase. The method recalculates the camera lens parameters based on the near and far plane values. The changes span multiple files, ensuring the method is accessible and functional across the application.Addition of the
recalulateCameraLensMethod:ARToolKitNFTclass:recalulateCameraLensmethod to theARToolKitNFTclass in bothARToolKitNFT_js.cppandARToolKitNFT_js_td.cpp. This method usesarglCameraFrustumRHto update the camera lens parameters based on the near and far planes. [1] [2]recalulateCameraLensmethod in the corresponding header files,ARToolKitNFT_js.handARToolKitNFT_js_td.h. [1] [2]Integration into Bindings:
recalulateCameraLensmethod to JavaScript by adding it to theEMSCRIPTEN_BINDINGSinARToolKitNFT_js_bindings.cpp. This allows the method to be called from the JavaScript environment.