Check directory permission in docker-entrypoint.sh with test -w
#930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ato
approved these changes
Aug 4, 2025
annesiri
added a commit
to statisticsnorway/ssbno-pywb
that referenced
this pull request
Aug 8, 2025
* Fix client-side replay error page + wabac.js update (webrecorder#945) * fixes for client-side replay - always serve top frame resource in client-side-replay mode, fixes webrecorder#936 - deps: bump wabac.js to 2.23.8 for additional fixes * skip test that relies on ait * Remove deprecated datetime.utcnow() Fixes webrecorder#913 * Use tz-aware datetimes for embargo checks (webrecorder#946) Fixes regression introduced in commit 6ae3de9 * Check directory permission in docker-entrypoint.sh with `test -w` (webrecorder#930) --------- Co-authored-by: Ilya Kreymer <ikreymer@users.noreply.github.com> Co-authored-by: Lisias <lisias.toledo@gmail.com> Co-authored-by: Tessa Walsh <tessa@bitarchivist.net> Co-authored-by: Natanael Arndt <arndtn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have replaced the individual comparison of the ids with a
test -w $VOLUME_DIRresp.! [ -w $VOLUME_DIR ]check.Motivation and Context
The comparison of the individual gid and uids of the user and the directory misses out, if the user has permission based on further groups.
Screenshots (if appropriate):
Types of changes
Checklist: