Add scope attribute support for table headers #7853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve and render the 'scope' attribute from th elements to improve table accessibility for screen readers.
There was a problem hiding this comment.
Pull Request Overview
Adds support for preserving and rendering the scope attribute on <th> elements to improve table accessibility.
- Extracts
scopefrom header<th>attributes into column configuration - Includes
scopewhen generating header cell HTML
Comments suppressed due to low confidence (1)
src/bootstrap-table.js:201
- [nitpick] The new
scopeoption should be documented in the public API docs or JSDoc comments so consumers know this attribute is now supported.
scope: $th.attr('scope'),
wenzhixin
reviewed
May 24, 2025
Comment on lines
374
to
+375
| Utils.sprintf(' data-field="%s"', column.field), | ||
| Utils.sprintf(' scope="%s"', column.scope), |
There was a problem hiding this comment.
Suggested change
| Utils.sprintf(' data-field="%s"', column.field), | |
| Utils.sprintf(' scope="%s"', column.scope), | |
| Utils.sprintf(' scope="%s"', column.scope), | |
| Utils.sprintf(' data-field="%s"', column.field), |
wenzhixin
reviewed
May 24, 2025
Comment on lines
+201
to
203
| scope: $th.attr('scope') ? $th.attr('scope') : undefined, | ||
| rowspan: $th.attr('rowspan') ? +$th.attr('rowspan') : undefined, | ||
| colspan: $th.attr('colspan') ? +$th.attr('colspan') : undefined |
There was a problem hiding this comment.
Suggested change
| scope: $th.attr('scope') ? $th.attr('scope') : undefined, | |
| rowspan: $th.attr('rowspan') ? +$th.attr('rowspan') : undefined, | |
| colspan: $th.attr('colspan') ? +$th.attr('colspan') : undefined | |
| rowspan: $th.attr('rowspan') ? +$th.attr('rowspan') : undefined, | |
| colspan: $th.attr('colspan') ? +$th.attr('colspan') : undefined, | |
| scope: $th.attr('scope') ? $th.attr('scope') : undefined |
There was a problem hiding this comment.
Suggest keeping the same order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve and render the 'scope' attribute from th elements to improve table accessibility for screen readers.
🤔Type of Request
🔗Resolves an issue?
Fix #7780
📝Changelog
💡Example(s)?
https://live.bootstrap-table.com/code/djhvscf/18817
☑️Self Check before Merge