Skip to content

PHPUnit 7 support #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PHPUnit 7 support #13

wants to merge 2 commits into from

Conversation

TiMESPLiNTER
Copy link

  • Adds support for PHPUnit 7.
  • Important!
  • Beware the BC.

@lex111
Copy link

lex111 commented Jun 1, 2018

ping @whatthejeff please merge this PR, it's really important!

@JeroenDeDauw JeroenDeDauw mentioned this pull request Aug 10, 2018
Closed
@JeroenDeDauw
Copy link
Contributor

This actually no longer works due to "syntaxCheck" usage now throwing a warning. Also writeProgress is missing a string type hint. No idea why the tests did not catch that. They do when I run them now though. I've pulled the two commits from this PR, fixed the mentioned issues and will do a release of https://github.com/JeroenDeDauw/nyancat-phpunit-resultprinter as jeroen/nyancat-phpunit-resultprinter. I rather not fork but it seems that Jeff no longer has the time or inclination to maintain this package. Happy to have the fork merged back into the main repo here.

@JeroenDeDauw
Copy link
Contributor

Released as v2.1.0: https://packagist.org/packages/jeroen/nyancat-phpunit-resultprinter

See also: #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TiMESPLiNTER @lex111 @JeroenDeDauw