Skip to content

Activity tab onboarding #5883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 3, 2025
Merged

Activity tab onboarding #5883

merged 8 commits into from
Sep 3, 2025

Conversation

Williamrai
Copy link
Collaborator

@Williamrai Williamrai commented Aug 29, 2025 •
edited
Loading

What does this do?

  • adds onboarding activity and views

Phabricator:
https://phabricator.wikimedia.org/T401612

Note: Waiting on resources from design

@Williamrai Williamrai added WIP Work in progress HOLD Will review as soon as other more pressing PRs are merged/released. labels Aug 29, 2025
@Williamrai Williamrai added Ready for Review and removed WIP Work in progress labels Aug 29, 2025
@Williamrai
- adds new resources
6bc64e4 
- adds onboarding preference and logic to show onboarding activity
@Williamrai
Merge remote-tracking branch 'origin/activityTab_design' into activit…
38be70d 
…yTab_onboarding

# Conflicts:
#	app/src/main/res/values-qq/strings.xml
#	app/src/main/res/values/strings.xml
@Williamrai Williamrai added WIP Work in progress and removed HOLD Will review as soon as other more pressing PRs are merged/released. Ready for Review labels Sep 3, 2025
@Williamrai Williamrai added Ready to merge PR passed design signoff and ready to be merged. and removed WIP Work in progress labels Sep 3, 2025
dbrant
dbrant requested changes Sep 3, 2025
View reviewed changes
Copy link
Member

@dbrant dbrant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny note inline, and also:

On my device, the whole layout overflows and requires scrolling to reach the Continue button. Can we keep the Continue / Learn more buttons floating at the bottom, above the rest of the content, and allow the content to scroll behind them? (i.e. put those buttons in a container with 16dp padding, and keep it pinned to the bottom.)

image

@Williamrai
Copy link
Collaborator Author

A tiny note inline, and also:

On my device, the whole layout overflows and requires scrolling to reach the Continue button. Can we keep the Continue / Learn more buttons floating at the bottom, above the rest of the content, and allow the content to scroll behind them? (i.e. put those buttons in a container with 16dp padding, and keep it pinned to the bottom.)

image

Fixed.

@Williamrai Williamrai requested a review from dbrant September 3, 2025 21:17
@dbrant dbrant merged commit c2fe4b9 into activityTab_design Sep 3, 2025
1 check passed
@dbrant dbrant deleted the activityTab_onboarding branch September 3, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooltey cooltey Awaiting requested review from cooltey cooltey is a code owner

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

Assignees
No one assigned
Labels
Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Williamrai @dbrant