Fixed locale-dependent parsing of decimal values in saved splits file #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXtremeExploit
requested changes
Sep 22, 2025
| #include "bind.h" | ||
| #include "component/components.h" | ||
| #include "main.h" | ||
| #include "main_css.h" |
There was a problem hiding this comment.
Looks like this line is causing the build error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes time precision loss when loading split files in non-English locales, which use "," instead of "." to separate integer and its fraction, ex. 3,1415 vs 3.1415
Tested in Polish locale where comma is the decimal separator
Results:
Split times like "5.673432" now load correctly as 5673432 microseconds instead of 5000000, regardless which separator is used.