[1.21.6] Overhaul owo ItemGroup #430
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension of a ItemGroup - Adjust Icons to be more date driven for use in data driven manipulation of item groups - Separate state from item group to allow for proper state on client vs server - Adjust data format for item groups to allow for more features and use endec - Inject owo extensions on server and client - Use item groups registry key rather than item group it self for Item settings
…issing config field
…esides tabs and enable support for condensed entries - Rework DispatchedEndec to use a builder for all the configurable values - Adjust Icon to allow for typeless data decoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to update owo's built-in
ItemGroupto be instead an extension on top of VanillasItemGroupto be more compatible with other mods and have better handling for Client/Server code.Features:
OwoItemGroupBuilderto either create/modify an ItemGroup, meaning anyItemGroupcan be easily modified in code to be an OwoItemGroupIcons are now data objects with requiredIconRenderto be registered inIconRendererRegistryOwoItemGroupStatehandles all states for active tabs and accessing the given entries for a givenOwoItemGroupCondensedEntrybased on Bedrock's feature, where a given collection of stacks is toggable to either hide or show with a cycling icon