[Android] Fix safe area miscalculation on HONOR phones #8084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, what android version you're running. It looks like a problem with edge to edge and not specific brand |
Contributor
Author
|
Problem with edge2edge and HONOR specifically, because everything works fine on e.g Samsung. OS is MagicOS 9 (Android 15) |
Contributor
Author
|
I see there are new additions to BottomTabsController.java which may cover my PR already, though I need to test it. Maybe PR is already obsolete. I'll let you know as soon as I can. |
Contributor
|
we still have to implement the edge to edge support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow bottomButtons layout breaks keyboard safe area on Honor (MagicOs) phone models.
Description:
We have an app with bottomTabs layout.
When we push some modal that has TextInput and focus it,
adjustResizedoesn't work and important views that are placed on bottom became hidden behind the keyboard. But only on Honor phones 🤷♂️Initial screen:
Before fix:
After fix:
Additional info:
react-native:0.77.3(with some patches from here)react-native-navigation:7.50.0softInputModeisadjustResizeDisclaimer
This is more of something to think about, rather that thorough merge request, as I'm not an advanced android developer and this works only for my case, but may break ton of others.
Screenshots are emulator representation of how it looks, not a real device screenshots.