Add support for PaddlePaddle Tensors for nb::ndarray
#1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensor. Some of the self-made tests won't pass. contig proc is broken, needs fixing.
Enigmatisms
commented
Jul 15, 2025
|
|
||
| @needs_paddle | ||
| def test60_check_paddle(): | ||
| assert t.check(paddle.zeros((1)).cpu()) |
There was a problem hiding this comment.
.cpu() can actually be removed. Other parts are fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Related topics
nb::ndarrayIntro
Hi! I’m a researcher from the PaddlePaddle team. After our conversation at SIGGRAPH Asia 2024 (where you recommended migrating from pybind11 to nanobind), I gave nanobind a try and was impressed by its performance. As part of this effort, I’ve extended
nb::ndarrayto supportpaddle.Tensor, allowing direct return of PaddlePaddle tensors from C++ vianb::paddle.This PR includes:
nb::paddle: Mirroringnb::pytorch’s behavior, with modifications innb_ndarray.cppfor consistent tensor handling.@needs_torch) to validate PaddlePaddle integration.nb::paddle(preview welcome—I’m unsure how it renders on the website).test_ndarray.py.This change maintains backward compatibility while enabling PaddlePaddle users to leverage nanobind’s efficiency. Looking forward to feedback!