Skip to content

Added tests for double get of a ref in C++ object #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tests/test_intrusive.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include <nanobind/nanobind.h>
#include <nanobind/stl/pair.h>
#include <nanobind/stl/string.h>
#include <nanobind/trampoline.h>
#include <nanobind/intrusive/counter.h>
#include <nanobind/intrusive/ref.h>
Expand Down Expand Up @@ -29,6 +30,27 @@ class PyTest : Test {
}
};


class Inner : public nb::intrusive_base {
public:
std::string get_name() const { return "Inner"; }
};

class Outter : public nb::intrusive_base {
public:
Outter()
{
m_inner = new Inner;
}

Inner& get_inner() { return *m_inner; }
Inner* get_inner_ptr() { return m_inner.get(); }
nb::ref<Inner> get_inner_ref() { return m_inner; }
private:
nb::ref<Inner> m_inner;
};


NB_MODULE(test_intrusive_ext, m) {
nb::intrusive_init(
[](PyObject *o) noexcept {
Expand Down Expand Up @@ -63,4 +85,14 @@ NB_MODULE(test_intrusive_ext, m) {
m.def("get_value_1", [](Test *o) { nb::ref<Test> x(o); return x->value(1); });
m.def("get_value_2", [](nb::ref<Test> x) { return x->value(2); });
m.def("get_value_3", [](const nb::ref<Test> &x) { return x->value(3); });


nb::class_<Inner, nb::intrusive_base>(m, "Inner")
.def("get_name", &Inner::get_name);

nb::class_<Outter, nb::intrusive_base>(m, "Outter")
.def(nb::init<>())
.def("get_inner", &Outter::get_inner)
.def("get_inner_ptr", &Outter::get_inner_ptr)
.def("get_inner_ref", &Outter::get_inner_ref);
}
15 changes: 15 additions & 0 deletions tests/test_intrusive.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,18 @@ def value(self, value):
del o
collect()
assert t.stats() == (1, 1)

def test05_inner_BREAKS(clean):
o = t.Outter()
assert o.get_inner().get_name() == "Inner"
assert o.get_inner().get_name() == "Inner"

def test06_inner_ref(clean):
o = t.Outter()
assert o.get_inner_ref().get_name() == "Inner"
assert o.get_inner_ref().get_name() == "Inner"

def test07_inner_ptr_BREAKS(clean):
o = t.Outter()
assert o.get_inner_ref().get_name() == "Inner"
assert o.get_inner_ref().get_name() == "Inner"
Loading