Skip to content

Use in-place operators in enum mask calculations #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

Use in-place operators in enum mask calculations #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/nb_enum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ void enum_append(PyObject *tp_, const char *name_, int64_t value_,
// In Python 3.11+, update the flag and bit masks by hand,
// since enum._proto_member.__set_name__ is not called in this code path.
if (t->flags & (uint32_t) enum_flags::is_flag) {
setattr(tp, "_flag_mask_", tp.attr("_flag_mask_") | val);
tp.attr("_flag_mask_") |= val;

bool is_single_bit = (value_ != 0) && (value_ & (value_ - 1)) == 0;
if (is_single_bit && hasattr(tp, "_singles_mask_"))
setattr(tp, "_singles_mask_", tp.attr("_singles_mask_") | val);
tp.attr("_singles_mask_") |= val;

int_ bit_length = int_(tp.attr("_flag_mask_").attr("bit_length")());
setattr(tp, "_all_bits_", (int_(2) << bit_length) - int_(1));
Expand Down
Loading