Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-pdf/src/Page/Canvas.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,14 @@ describe('Canvas', () => {

expect.assertions(1);

await expect(onRenderSuccessPromise).resolves.toMatchObject([{}]);
await expect(onRenderSuccessPromise).resolves.toMatchObject([
{},
{
annotationMode: 1,
canvasContext: expect.any(Object),
viewport: page.getViewport({ scale: 1, rotation: 0 }),
},
]);

restoreConsole();
});
Expand Down
6 changes: 3 additions & 3 deletions packages/react-pdf/src/Page/Canvas.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ export default function Canvas(props: CanvasProps): React.ReactElement {
/**
* Called when a page is rendered successfully.
*/
function onRenderSuccess() {
function onRenderSuccess(renderContext: RenderParameters) {
if (!page) {
// Impossible, but TypeScript doesn't know that
return;
}

if (onRenderSuccessProps) {
onRenderSuccessProps(makePageCallback(page, scale));
onRenderSuccessProps(makePageCallback(page, scale), renderContext);
}
}

Expand Down Expand Up @@ -126,7 +126,7 @@ export default function Canvas(props: CanvasProps): React.ReactElement {
.then(() => {
canvas.style.visibility = '';

onRenderSuccess();
onRenderSuccess(renderContext);
})
.catch(onRenderError);

Expand Down
3 changes: 2 additions & 1 deletion packages/react-pdf/src/shared/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import type {
TypedArray,
DocumentInitParameters,
RefProxy,
RenderParameters,
StructTreeNode,
TextContent,
TextItem,
Expand Down Expand Up @@ -119,7 +120,7 @@ export type OnRenderAnnotationLayerSuccess = () => void;

export type OnRenderError = OnError;

export type OnRenderSuccess = (page: PageCallback) => void;
export type OnRenderSuccess = (page: PageCallback, renderContext: RenderParameters) => void;

export type OnRenderTextLayerError = OnError;

Expand Down