fix: ASCII table CSS styling affecting other icons on page #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The styling from was indavertantly colouring other icons on the page, when it should have only been modifying the colours of the symbols in the SVGs. This has been fixed by grouping the individual paths that make up the symbols into a `symbols` group, ensuring that its ID is set to `symbols` in the object properties in Inkscape, clearing existing CSS styling from the SVG and updating the CSS selector in `src/css/custom.css` to only modify the `symbols` group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styling from was inadvertently colouring other icons on the page, when it should have only been modifying the colours of the symbols in the SVGs.
This has been fixed by grouping the individual paths that make up the symbols into a
symbolsgroup, ensuring that its ID is set tosymbolsin the object properties in Inkscape, clearing existing CSS styling from the SVG and updating the CSS selector insrc/css/custom.cssto only modify thesymbolsgroup.