feat: logo & favicon follow theme preference #256
Merged
+95
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The colour of the logo in the favicon is determined by a stylesheet in the SVG itself - it uses `prefers-color-scheme` in order to colour the logo. It does not follow the theme of the website but follows the browser/OS choice. The SVG in this commit had to be manually edited, since Inkscape didn't want to play nice with the CSS. If this file gets edited in the future, be careful to not accidentally break this functionality. Using an SVG here was preferred over using the existing `favicon-white.png` and `favicon.ico` because Docusaurus did not provide a handy feature to toggle between the light/dark mode favicons, in the same way that it did for the logo in the navbar (with `navbar.logo.src` and `navbar.logo.srcDark`).
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the logo in the navbar follows the website theme...
...and that the favicon follows the browser/OS preference.
Tested on Chromium (top) and Firefox (bottom) by changing between the light/dark themes manually. The Chrome(ium) version takes a moment to update when toggling between the themes.