-
Notifications
You must be signed in to change notification settings - Fork 894
Update Renesas RZ examples #9047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Use xSPI0 boot mode - Update FSP from v1.3 to v2.0.0 - Simplify UART - Migrate new User Ctx - Update README - Fix SCE TLS on RA6M4
🛟 Devin Lifeguard found 4 likely issues in this PR
@miyazakh |
- addressed code review by devin
retest this please
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Renesas RZ examples to support FSP version 2.0.0 and implements several improvements including xSPI0 boot mode support, UART simplification, User Context migration, and various bug fixes.
- Update FSP from v1.3 to v2.0.0 with support for new RSIP API versions
- Migrate to xSPI0 boot mode and simplify UART implementation
- Fix SCE TLS functionality on RA6M4 and improve memory management
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
wolfssl/wolfcrypt/sha.h | Updates include path for Renesas FSPSM internal header |
wolfssl/wolfcrypt/port/Renesas/renesas_tsip_internal.h | Removes devId field from internal structure |
wolfssl/wolfcrypt/port/Renesas/renesas_fspsm_internal.h | Adds new context fields and version-specific conditions |
wolfssl/wolfcrypt/port/Renesas/renesas-tsip-crypt.h | Moves devId field to public structure |
wolfssl/wolfcrypt/port/Renesas/renesas-fspsm-types.h | Adds version checks and new API mappings |
wolfssl/wolfcrypt/port/Renesas/renesas-fspsm-crypt.h | Updates includes and removes unused macro |
wolfcrypt/test/test.c | Adds cleanup for Renesas crypto callback |
wolfcrypt/src/sha*.c | Adds version-specific memory cleanup conditions |
wolfcrypt/src/port/Renesas/*.c | Multiple files with API version handling and bug fixes |
IDE/Renesas/e2studio/RZN2L/test/src/*.c | Updates for xSPI0 boot mode and UART simplification |
Comments suppressed due to low confidence (3)
wolfcrypt/src/port/Renesas/renesas_tsip_util.c:255
- [nitpick] Adding the ssl NULL check is good defensive programming, but consider checking ssl before user_ctx since ssl is used in the error message context. The order of checks should follow the order of usage.
{
wolfcrypt/src/port/Renesas/renesas_fspsm_aes.c:236
- Parameter name inconsistency: the parameter was renamed from 'cipher_lengh' to 'cipher_length' (fixing the typo), but on line 247 it's still referenced as 'cipher_lengh'. Ensure all parameter names are consistent.
uint32_t* cipher_length)
IDE/Renesas/e2studio/RZN2L/test/src/test/wolfssl_rsip_unit_test.c
Outdated
Show resolved
Hide resolved
retest this please
|
Description
Includes the following changes and updates:
Testing
Run examples including Crypt, benchmark and Client/Server Renesas RZN2L RSK and RA6M4
Checklist