Woomob 1674 hide view order for missing orders (#16335)

Author: RafaelKayumov

WooCommerce/Classes/Extensions/Booking+Helpers.swift

@@ -19,6 +19,10 @@ extension Booking {
             .joined(separator: "  •  ")
     }
 
+    var hasAssociatedOrder: Bool {
+        return orderID > 0
+    }
+
     private enum Localization {
         static let guest = NSLocalizedString(
             "bookings.guest",

WooCommerce/Classes/ViewModels/Booking Details/BookingDetailsViewModel.swift

@@ -27,6 +27,7 @@ final class BookingDetailsViewModel: ObservableObject {
 
     @Published private(set) var navigationTitle = ""
     @Published private(set) var sections: [Section] = []
+    @Published private(set) var isViewOrderAvailable = true
     @Published var notice: Notice?
 
     var bookingAttendanceStatus: BookingAttendanceStatus {
@@ -86,6 +87,7 @@ private extension BookingDetailsViewModel {
 
     func updateDisplayProperties(from booking: Booking) {
         navigationTitle = Self.navigationTitle(for: booking)
+        isViewOrderAvailable = booking.hasAssociatedOrder
 
         headerContent.update(with: booking)
 

WooCommerce/Classes/ViewModels/Booking Details/PaymentContent.swift

@@ -28,9 +28,8 @@ extension BookingDetailsViewModel {
 
             actions = [
                 .markAsPaid,
-                .issueRefund,
-                .viewOrder
-            ]
+                .issueRefund
+            ] + (booking.hasAssociatedOrder ? [.viewOrder] : [])
         }
     }
 }

WooCommerce/Classes/ViewRelated/Bookings/Booking Details/BookingDetailsView.swift

@@ -64,8 +64,10 @@ struct BookingDetailsView: View {
                     Button(Localization.markAsPaid) {
                         print("On mark as paid tap")
                     }
-                    Button(Localization.viewOrder) {
-                        viewModel.navigateToOrderDetails()
+                    if viewModel.isViewOrderAvailable {
+                        Button(Localization.viewOrder) {
+                            viewModel.navigateToOrderDetails()
+                        }
                     }
                     Button(Localization.cancelBookingAction, role: .destructive) {
                         showingCancelAlert = true

WooCommerce/WooCommerceTests/ViewRelated/Bookings/BookingDetailsViewModelTests.swift

@@ -357,4 +357,31 @@ final class BookingDetailsViewModelTests: XCTestCase {
 
         XCTAssertFalse(containsAttendanceSection)
     }
+
+    func test_view_order_is_hidden_when_booking_order_id_is_invalid() {
+        // Given
+        let booking = Booking.fake().copy(
+            orderID: 0
+        )
+
+        // When
+        let viewModel = BookingDetailsViewModel(booking: booking, stores: storesManager)
+
+        // Then
+        let paymentSection = viewModel.sections.first { section in
+            if case .payment = section.content {
+                return true
+            }
+            return false
+        }
+
+        guard let paymentSection = paymentSection,
+              case let .payment(paymentContent) = paymentSection.content else {
+            XCTFail("Payment section not found")
+            return
+        }
+
+        XCTAssertFalse(viewModel.isViewOrderAvailable)
+        XCTAssertFalse(paymentContent.actions.contains(.viewOrder))
+    }
 }