[Tooling] Use ReleasesV2 version as the source of truth during Code Freeze #16296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
added
the
category: tooling
iangmaia
force-pushed
the
iangmaia/fail-when-code-freeze-version-mismatch
branch
from
0f648e8 to
16ed476
Compare
iangmaia
force-pushed
the
iangmaia/fail-when-code-freeze-version-mismatch
branch
2 times, most recently
from
4f7ba8e to
51a65b4
Compare
iangmaia
changed the title
iangmaia
force-pushed
the
iangmaia/fail-when-code-freeze-version-mismatch
branch
2 times, most recently
from
1cc7d05 to
8a4865e
Compare
mokagio
approved these changes
Nov 11, 2025
fastlane/Fastfile
Outdated
Comment on lines
1413
to
1414
| version_short ||= VERSION_FILE.read_release_version | ||
| # Read the current release version from the .xcconfig file and parse it into an AppVersion object |
Contributor
There was a problem hiding this comment.
Suggested change
| version_short ||= VERSION_FILE.read_release_version | |
| # Read the current release version from the .xcconfig file and parse it into an AppVersion object | |
| # Read the current release version from the .xcconfig file and parse it into an AppVersion object, | |
| # unless already given | |
| version_short ||= VERSION_FILE.read_release_version |
Contributor
There was a problem hiding this comment.
Alternatively, we could just remove the comment given the code is quite straightforward to read.
Suggested change
| version_short ||= VERSION_FILE.read_release_version | |
| # Read the current release version from the .xcconfig file and parse it into an AppVersion object | |
| version_short ||= VERSION_FILE.read_release_version |
iangmaia
force-pushed
the
iangmaia/fail-when-code-freeze-version-mismatch
branch
from
8a4865e to
ff9b7e2
Compare
…of just showing a warning
…hroughout code freeze
iangmaia
force-pushed
the
iangmaia/fail-when-code-freeze-version-mismatch
branch
from
0ba464b to
9336d5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See AINFRA-1478
Description
This PR enhances the version handling added in the previous iteration to assume the version received by the code freeze lane as the source of truth, ignoring potential mismatches between the ReleasesV2 version and the project's computed version.
Testing
You can make sure the calculated release branch, current version and the next version are correctly shown in the "Continue" prompt, remembering to answer
Nwhen asked to continue to cancel the code freeze.To avoid unexpected results, comment out the lines doing
ensure_git_status_cleanandFastlane::Helper::GitHelper.checkout_and_pull(DEFAULT_BRANCH)at the beginning of the lane.You can run the
start_code_freezelane, with and without the version parameters:bundle exec fastlane start_code_freezebundle exec fastlane start_code_freeze version:30.6This will be fully tested in the next release cycle during code freeze.