Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Oct 31, 2025

Part of WOOMOB-1240

Description

This PR integrates the API for filtering bookings. Changes include:

  • Unifies all filters in one param for loading bookings in BookingsRemote and updates all call sites accordingly.
  • Updates the requests on All tab (both booking list and search) to apply filters.
  • Updates the predicate for the results controller on the booking list following the filters.
  • Updates BookingDateTimeFilterView to convert the selected dates to clear time zone details. The reason is that Bookings backend treats dates as fixed time without time zone details. More details can be found on the Slack thread: p1759398245019489-slack-C09FHQNQERG.

Known issues:

  • Empty state views would need to be updated in a subsequent PR after all designs are updated and finalized.
  • Filtering attendance status and payment status "Cancelled" would cause the requests to fail. I'll check again with the team and update the options as these are still pending decision.

Test Steps

  1. Log in to a CIAB store with existing bookings.
  2. Navigate to Bookings tab > All > Filters.
  3. Select any filter options (except for attendance and payment statuses "Cancelled").
  4. Confirm that the list is reloaded correctly.
  5. Regression check: confirm that the Today and Upcoming tabs still show correct bookings.

Screenshots

Simulator.Screen.Recording.-.iPad.mini.A17.Pro.-.2025-10-31.at.17.48.51.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.7 milestone Oct 31, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Oct 31, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 31, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16302-baa0954
Version23.5
Bundle IDcom.automattic.alpha.woocommerce
Commitbaa0954
Installation URL4adegvp4krga8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Base automatically changed from woomob-1240-search-bookable-products to trunk October 31, 2025 10:40
@itsmeichigo itsmeichigo marked this pull request as ready for review October 31, 2025 10:52
@adborbas adborbas self-assigned this Nov 3, 2025
Copy link
Contributor

@adborbas adborbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@itsmeichigo itsmeichigo merged commit e712965 into trunk Nov 3, 2025
17 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1240-filter-api-integration branch November 3, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants