Skip to content

Conversation

@adalpari
Copy link
Contributor

@adalpari adalpari commented Oct 24, 2025

Description

This PR hides the "Ask the Bots" and "Ask Happiness Engineers" support options in the WordPress variant of the app while keeping them visible in the Jetpack variant.

Testing instructions

  1. Build WP app
  2. Enable MODERN_SUPPORT FF
  3. Go to "Me" -> Help & support
  • Verify "Ask the Bots" and "Ask Happiness Engineers" entries are hidden
Screenshot 2025-10-24 at 10 16 36
  1. Build JP app
  2. Enable MODERN_SUPPORT FF
  3. Go to "Me" -> Help & support
  • Verify "Ask the Bots" and "Ask Happiness Engineers" entries are shown
Screenshot 2025-10-24 at 10 09 21

@adalpari adalpari requested a review from Copilot October 24, 2025 07:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR hides the "Ask the Bots" and "Ask Happiness Engineers" support options in the WordPress variant of the app while keeping them visible in the Jetpack variant. The change ensures that these AI-powered support features are only available in the Jetpack app.

Key Changes:

  • Modified SupportViewModel to check both access token presence and Jetpack app variant before showing bot/HE options
  • Updated test assertions to verify variant-specific behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
WordPress/src/main/java/org/wordpress/android/support/main/ui/SupportViewModel.kt Added BuildConfig.IS_JETPACK_APP check to conditionally show support options based on app variant
WordPress/src/test/java/org/wordpress/android/support/main/ui/SupportViewModelTest.kt Updated test assertions to expect variant-specific behavior with explanatory comments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 24, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 24, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
FlavorJalapeno
Build TypeDebug
Versionpr22313-f431deb
Commitf431deb
Direct Downloadwordpress-prototype-build-pr22313-f431deb.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 24, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
FlavorJalapeno
Build TypeDebug
Versionpr22313-f431deb
Commitf431deb
Direct Downloadjetpack-prototype-build-pr22313-f431deb.apk
Note: Google Login is not supported on these builds.

@sonarqubecloud
Copy link

@adalpari adalpari marked this pull request as ready for review October 24, 2025 08:27
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.43%. Comparing base (f604c81) to head (f431deb).
⚠️ Report is 4 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #22313   +/-   ##
=======================================
  Coverage   39.43%   39.43%           
=======================================
  Files        2192     2192           
  Lines      104938   104938           
  Branches    14926    14928    +2     
=======================================
  Hits        41380    41380           
  Misses      60072    60072           
  Partials     3486     3486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants