-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CMM-891: support: hide bots and he entries in WP #22313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
CMM-891: support: hide bots and he entries in WP #22313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR hides the "Ask the Bots" and "Ask Happiness Engineers" support options in the WordPress variant of the app while keeping them visible in the Jetpack variant. The change ensures that these AI-powered support features are only available in the Jetpack app.
Key Changes:
- Modified
SupportViewModelto check both access token presence and Jetpack app variant before showing bot/HE options - Updated test assertions to verify variant-specific behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
WordPress/src/main/java/org/wordpress/android/support/main/ui/SupportViewModel.kt |
Added BuildConfig.IS_JETPACK_APP check to conditionally show support options based on app variant |
WordPress/src/test/java/org/wordpress/android/support/main/ui/SupportViewModelTest.kt |
Updated test assertions to expect variant-specific behavior with explanatory comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Generated by 🚫 Danger |
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22313-f431deb | |
| Commit | f431deb | |
| Direct Download | wordpress-prototype-build-pr22313-f431deb.apk |
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22313-f431deb | |
| Commit | f431deb | |
| Direct Download | jetpack-prototype-build-pr22313-f431deb.apk |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #22313 +/- ##
=======================================
Coverage 39.43% 39.43%
=======================================
Files 2192 2192
Lines 104938 104938
Branches 14926 14928 +2
=======================================
Hits 41380 41380
Misses 60072 60072
Partials 3486 3486 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. 🚀





Description
This PR hides the "Ask the Bots" and "Ask Happiness Engineers" support options in the WordPress variant of the app while keeping them visible in the Jetpack variant.
Testing instructions
MODERN_SUPPORTFFMODERN_SUPPORTFF