CMM-1037 Pagelist empty view #22413

nbradbury · 2025-12-10T18:23:38Z

Partially addresses CMM-1037

As a companion to this previous PR, this PR updates the page list empty view to remove the outdated illustrations and adds a subtitle to the "Published pages" empty list.

To test, spin up a site without any pages, or delete all the pages in an existing site, and verify the empty views work as expected.

Note that your published page list may shows this homepage item:

If it does, modify this line to just it.

Screen_recording_20251210_131220.mp4

…dded subtitle resource

nbradbury · 2025-12-10T18:24:00Z

@claude

claude · 2025-12-10T18:24:20Z

Claude finished @nbradbury's task in 1m 42s —— View job

Code Review Complete ✓

I've conducted a comprehensive code review of this PR. Overall, the implementation is clean and well-structured. Here are my findings:

✅ Positive Observations

Clean Refactoring: The PR successfully removes the outdated illustration and simplifies the Empty data class by removing the isImageVisible parameter
Consistent Pattern: The change to use named parameters (titleResource, subtitleResource) improves code readability
Good Scope: The changes are focused and address the stated objective without unnecessary modifications
Resource Management: Properly removes the unused drawable resource (img_illustration_pages_104dp.xml)

🐛 Critical Issue: Logic Error in PageItemViewHolder.kt

Location: PageItemViewHolder.kt:347-352

There's a critical bug in the subtitle visibility logic:

pageItem.subtitleResource?.let { subtitleResource ->
    emptyView.subtitle.text = emptyView.resources.getString(subtitleResource)
    emptyView.subtitle.visibility = View.VISIBLE
} ?: {
    emptyView.subtitle.visibility = View.GONE
}

Problem: The Elvis operator (?:) is followed by a lambda that's never executed. In Kotlin, let { } ?: { } doesn't work as intended here - the right-hand side lambda is just created but never called.

Fix: Remove the braces on the else clause:

pageItem.subtitleResource?.let { subtitleResource ->
    emptyView.subtitle.text = emptyView.resources.getString(subtitleResource)
    emptyView.subtitle.visibility = View.VISIBLE
} ?: run {
    emptyView.subtitle.visibility = View.GONE
}

Or use a more straightforward approach:

if (pageItem.subtitleResource != null) {
    emptyView.subtitle.text = emptyView.resources.getString(pageItem.subtitleResource)
    emptyView.subtitle.visibility = View.VISIBLE
} else {
    emptyView.subtitle.visibility = View.GONE
}

Impact: Currently, when subtitleResource is null, the subtitle visibility is never set to GONE, which could leave stale subtitles visible from previous views.

📝 Other Observations

String Updates: The updated strings are more conversational and user-friendly:
- "You haven't published any pages - yet!" (added dash and exclamation)
- "Why not create one?" (new encouraging subtitle)
Parameter Naming: Renaming textResource → titleResource is a good improvement for semantic clarity
Testing: The existing test file (PageListViewModelTest.kt) doesn't appear to have tests for empty states with subtitles. Consider adding a test case to verify the new subtitle functionality works correctly for published pages.

🔍 Code Quality Check

✅ Line length: All lines are under 120 characters (CLAUDE.md requirement)
✅ No use of deprecated APIs
✅ Proper null safety handling (except for the bug noted above)
✅ Consistent code style with existing codebase
⚠️ No new tests added for the subtitle feature

🎯 Recommendations

[CRITICAL] Fix the subtitle visibility logic bug in PageItemViewHolder.kt:347-352 (see inline comment)
[RECOMMENDED] Add unit tests to verify the subtitle appears for empty published pages and doesn't appear for other empty states
[OPTIONAL] Consider testing on a device to ensure the empty view displays correctly without the illustration

dangermattic · 2025-12-10T18:24:25Z

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

claude · 2025-12-10T18:25:59Z

WordPress/src/main/java/org/wordpress/android/ui/pages/PageItemViewHolder.kt

+                pageItem.subtitleResource?.let { subtitleResource ->
+                    emptyView.subtitle.text = emptyView.resources.getString(subtitleResource)
+                    emptyView.subtitle.visibility = View.VISIBLE
+                } ?: {
+                    emptyView.subtitle.visibility = View.GONE
+                }


Critical Bug: This Elvis operator with a lambda doesn't work as expected. The lambda { emptyView.subtitle.visibility = View.GONE } is created but never executed.

Current behavior: When subtitleResource is null, nothing happens, leaving the subtitle potentially visible from a previous view.

Suggested fix:

Suggested change

pageItem.subtitleResource?.let { subtitleResource ->

emptyView.subtitle.text = emptyView.resources.getString(subtitleResource)

emptyView.subtitle.visibility = View.VISIBLE

} ?: {

emptyView.subtitle.visibility = View.GONE

}

pageItem.subtitleResource?.let { subtitleResource ->

emptyView.subtitle.text = emptyView.resources.getString(subtitleResource)

emptyView.subtitle.visibility = View.VISIBLE

} ?: run {

emptyView.subtitle.visibility = View.GONE

}

Or use a simpler if/else:

if (pageItem.subtitleResource != null) { emptyView.subtitle.text = emptyView.resources.getString(pageItem.subtitleResource) emptyView.subtitle.visibility = View.VISIBLE } else { emptyView.subtitle.visibility = View.GONE }

This Elvis operator with a lambda doesn't work as expected.

🤦

Fixed in 755d3ca

wpmobilebot · 2025-12-10T18:51:11Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22413-c54c3ba
	Commit	`c54c3ba`
	Direct Download	`jetpack-prototype-build-pr22413-c54c3ba.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2025-12-10T18:52:15Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22413-c54c3ba
	Commit	`c54c3ba`
	Direct Download	`wordpress-prototype-build-pr22413-c54c3ba.apk`

Note: Google Login is not supported on these builds.

sonarqubecloud · 2025-12-10T19:35:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-12-10T20:02:18Z

Codecov Report

❌ Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.09%. Comparing base (edb1fc8) to head (c54c3ba).

Files with missing lines	Patch %	Lines
...press/android/viewmodel/pages/PageListViewModel.kt	0.00%	5 Missing ⚠️
...droid/viewmodel/pages/PageParentSearchViewModel.kt	50.00%	2 Missing ⚠️
...ess/android/viewmodel/pages/SearchListViewModel.kt	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #22413      +/-   ##
==========================================
- Coverage   39.09%   39.09%   -0.01%     
==========================================
  Files        2207     2207              
  Lines      106858   106864       +6     
  Branches    15159    15159              
==========================================
+ Hits        41776    41778       +2     
- Misses      61566    61570       +4     
  Partials     3516     3516

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nbradbury added 5 commits December 10, 2025 12:37

Added temp code to remove virtual homepage item

0de6ac2

Removed empty view image and deleted img_illustration_pages_104dp

bef6b35

Removed empty view image, deleted img_illustration_pages_104dp, and a…

bf5b68d

…dded subtitle resource

Ensure subtitle appears for empty published view

48dc907

Removed image resource from model

0741b3e

nbradbury added Posts + Pages Tech Debt labels Dec 10, 2025

claude bot reviewed Dec 10, 2025

View reviewed changes

added missing run

755d3ca

nbradbury added 2 commits December 10, 2025 14:20

Fixed tests

a720057

Fixed detekt errors

c54c3ba

nbradbury requested a review from adalpari December 10, 2025 19:35

nbradbury marked this pull request as ready for review December 10, 2025 20:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CMM-1037 Pagelist empty view #22413

CMM-1037 Pagelist empty view #22413

nbradbury commented Dec 10, 2025

Uh oh!

nbradbury commented Dec 10, 2025

Uh oh!

claude bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

dangermattic commented Dec 10, 2025 •

edited

Loading

Uh oh!

claude bot Dec 10, 2025

Uh oh!

nbradbury Dec 10, 2025

Uh oh!

wpmobilebot commented Dec 10, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 10, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Dec 10, 2025

Uh oh!

codecov bot commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CMM-1037 Pagelist empty view #22413

Are you sure you want to change the base?

CMM-1037 Pagelist empty view #22413

Conversation

nbradbury commented Dec 10, 2025

Uh oh!

nbradbury commented Dec 10, 2025

Uh oh!

claude bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Complete ✓

✅ Positive Observations

🐛 Critical Issue: Logic Error in PageItemViewHolder.kt

📝 Other Observations

🔍 Code Quality Check

🎯 Recommendations

Uh oh!

dangermattic commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

nbradbury Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Dec 10, 2025

Quality Gate passed

Uh oh!

codecov bot commented Dec 10, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

claude bot commented Dec 10, 2025 •

edited

Loading

dangermattic commented Dec 10, 2025 •

edited

Loading

wpmobilebot commented Dec 10, 2025 •

edited

Loading

wpmobilebot commented Dec 10, 2025 •

edited

Loading