Skip to content

Add integer division method Num.quo #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add integer division method Num.quo #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad52461
Update wren_core.c
PureFox48 Mar 5, 2023
1b046dc
Create quo.wren
PureFox48 Mar 5, 2023
d7b6037
Update quo.wren
PureFox48 Mar 5, 2023
51dfe00
Update num.markdown
PureFox48 Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions doc/site/modules/core/num.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,18 @@ itself is returned.

Raises this number (the base) to `power`. Returns `nan` if the base is negative.

### **quo**(other)

Returns the quotient of this number and `other` rounded, if not already an integer, to the nearest integer towards zero. It is equivalent to: `(this/other).truncate`.

<pre class="snippet">
System.print(10.quo(4)) //> 2
System.print(10.quo(-4)) //> -2
System.print(15.4.quo(3.6)) //> 4
</pre>

It is a runtime error if `other` is not a number.

### **round**

Rounds the number to the nearest integer.
Expand Down
10 changes: 10 additions & 0 deletions src/vm/wren_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,15 @@ DEF_PRIMITIVE(num_pow)
RETURN_NUM(pow(AS_NUM(args[0]), AS_NUM(args[1])));
}

DEF_PRIMITIVE(num_quo)
{
if (!validateNum(vm, args[1], "Other value")) return false;

double value = AS_NUM(args[0]);
double other = AS_NUM(args[1]);
RETURN_NUM(trunc(value/other));
}

DEF_PRIMITIVE(num_fraction)
{
double unused;
Expand Down Expand Up @@ -1396,6 +1405,7 @@ void wrenInitializeCore(WrenVM* vm)
PRIMITIVE(vm->numClass, "...(_)", num_dotDotDot);
PRIMITIVE(vm->numClass, "atan(_)", num_atan2);
PRIMITIVE(vm->numClass, "pow(_)", num_pow);
PRIMITIVE(vm->numClass, "quo(_)", num_quo);
PRIMITIVE(vm->numClass, "fraction", num_fraction);
PRIMITIVE(vm->numClass, "isInfinity", num_isInfinity);
PRIMITIVE(vm->numClass, "isInteger", num_isInteger);
Expand Down
16 changes: 16 additions & 0 deletions test/core/number/quo.wren
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
System.print(10.quo(4)) // expect: 2
System.print(10.quo(-4)) // expect: -2
System.print((-10).quo(4)) // expect: -2
System.print((-10).quo(-4)) // expect: 2
System.print(15.4.quo(3.6)) // expect: 4
System.print(15.4.quo(-3.6)) // expect: -4

// Divide by zero.
System.print(3.quo(0)) // expect: infinity
System.print((-3).quo(0)) // expect: -infinity
System.print(0.quo(0)) // expect: nan
System.print((-0).quo(0)) // expect: nan
System.print(3.quo(-0)) // expect: -infinity
System.print((-3).quo(-0)) // expect: infinity
System.print(0.quo(-0)) // expect: nan
System.print((-0).quo(-0)) // expect: nan