Skip to content

WhereSequence: improve iteration performance by caching value lookup #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WhereSequence: improve iteration performance by caching value lookup #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/vm/wren_core.wren
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,16 +169,25 @@ class WhereSequence is Sequence {
construct new(sequence, fn) {
_sequence = sequence
_fn = fn
_cache_val = null
_cache_iter = null
}

iterate(iterator) {
while (iterator = _sequence.iterate(iterator)) {
if (_fn.call(_sequence.iteratorValue(iterator))) break
var val = _sequence.iteratorValue(iterator)
if (_fn.call(val)) {
_cache_val = val
_cache_iter = iterator
break
}
}
return iterator
}

iteratorValue(iterator) { _sequence.iteratorValue(iterator) }
iteratorValue(iterator) {
if (iterator == _cache_iter) return _cache_val else return _sequence.iteratorValue(iterator)
}
}

class String is Sequence {
Expand Down
13 changes: 11 additions & 2 deletions src/vm/wren_core.wren.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,16 +171,25 @@ static const char* coreModuleSource =
" construct new(sequence, fn) {\n"
" _sequence = sequence\n"
" _fn = fn\n"
" _cache_val = null\n"
" _cache_iter = null\n"
" }\n"
"\n"
" iterate(iterator) {\n"
" while (iterator = _sequence.iterate(iterator)) {\n"
" if (_fn.call(_sequence.iteratorValue(iterator))) break\n"
" var val = _sequence.iteratorValue(iterator)\n"
" if (_fn.call(val)) {\n"
" _cache_val = val\n"
" _cache_iter = iterator\n"
" break\n"
" }\n"
" }\n"
" return iterator\n"
" }\n"
"\n"
" iteratorValue(iterator) { _sequence.iteratorValue(iterator) }\n"
" iteratorValue(iterator) {\n"
" if (iterator == _cache_iter) return _cache_val else return _sequence.iteratorValue(iterator)\n"
" }\n"
"}\n"
"\n"
"class String is Sequence {\n"
Expand Down