Skip to content

Yet Logstore Work 2024 #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 260 commits into from
Feb 10, 2025
Merged

Yet Logstore Work 2024 #861

merged 260 commits into from
Feb 10, 2025

Conversation

milt
Copy link
Contributor

@milt milt commented Dec 12, 2024

Description
This PR:

  • adds ~100 new events
  • makes numerous improvements to existing events
  • makes numerous test improvements to reduce boilerplate

PR Type

  • Fix, Enhancement

cliffcaseyyet and others added 30 commits May 17, 2024 13:30
@cliffcaseyyet
removing unnecessary docs
9de5d27
@milt
attempt to make sending actor name optional
324608b
@milt
add configurable account homePage
2c7108a
@milt
add new defaults to test
d7fc83d
@milt
accomodate test copypasta
8aa2ef3
@milt
Merge pull request #2 from yetanalytics/conformant_actor
d12d5a9 
Enable conformant actors
@milt
add universal debug event (#4)
15ff5ee 
* add universal debug event

* fancy dynamic object for debuggrel

* refactor util fn

* tolerant debug event

* unserialize event other
@milt
reenable build matrix and chill code checker
d44d91d
@cliffcaseyyet
Merge pull request #6 from yetanalytics/ci_concerns_2
ca4e21a 
reenable build matrix and chill code checker
@cliffcaseyyet
Merge pull request #1 from yetanalytics/timestamp_and_formatting_and_…
851537f 
…docker_fix

Timestamp and formatting and docker fix
@milt
attempt downgrade of npm (#8)
4edbefb
@invaliduser
adds badge_awarded event and tests, improves event exception handling
2e60f8d
@cliffcaseyyet @invaliduser
wip commit for badge_revoked
8d06c7a
@invaliduser
wip
8ef1deb
@invaliduser
revoked tests
d44f3b3
@invaliduser
tests
07c414f
@invaliduser
further
80d6b8f
@invaliduser
further tests
ad4900b
@invaliduser
further tests
fcd2631
@invaliduser
further
9fd7ee0
@invaliduser
further
fe16b3b
@invaliduser
further
107b78a
@invaliduser
remove extraneous calendar stuff
4ec2891
@invaliduser
Merge pull request #7 from yetanalytics/badge_awarded
c5fcb34 
badge awarded
@milt
first crack at ccc with failing tests
8c6239a
@milt
valid xapi contextActivities (#10)
38108f1
@milt
updated expected statement
8e16e1a
@milt
correct event
8c2850b
@milt
Merge branch 'master' into course_category_created
69f6a0c
@milt
add event id everything else seems to have
58fc991
milt and others added 11 commits November 22, 2024 14:14
@milt
Tool certificate (#61)
8cfa0a5 
* cert issued

* certificate verified

* certificate revoked

* attempt to add tool_cert plugin in CI

* try actual repo
@milt
Mod quiz (#64)
a630517 
* relax equality looking for correct t/f answer

* Correct match question id relation

* correct matching response

* correct choices response

* correct response on gapselect/sequencing

* correct truefalse response

* fix numerical

* refactor numeric and relax types

* attempt_becameoverdue

* question_manually_graded

* make becameoverdue attempt-centric, improve attempt name

* refactor review

* attempt_centric attempt started

* refactor attempt_viewed

* remove unneeded cast

* reshape submitted
@milt
Mod assign (#65)
7053321 
* refactor out assign submission object

* use assign_submission in submitted evt

* submission (un)lock

* submission viewed
@milt
Course module completion disambiguation (#66)
fe77291 
* switch survey to submitted to remove conflict

* disambiguate scorm content from module

* scos dont have intros
@invaliduser @milt
notes (#52)
fdfa74c 
* notes

* pr feedback

* note-object

* note_object util fn

* remove double

* fix phpdoc

* moved course note to get_activity ns

* style and convention

* a little more style

---------

Co-authored-by: Milton Reder <milt@yetanalytics.com>
@milt @invaliduser
Calendar subscription (#67)
e58ba23 
* calendar_subscription consolidation

* calendar_sub wip

* dont mess with the debug event

* fix up calendar subscriptions for shipping

* clean up docs

* correct test docs

* refactor subscription object

---------

Co-authored-by: Daniel Bell <daniel@yetanalytics.com>
@milt
badge updated (#68)
29b32a3
@milt
Field Consistency & Bugfixes (#69)
a7fc6a2 
* require context language

* refactor default context

* ensure objectType, also message id fixes
@milt
name is not an integer (#70)
1982fdd
@milt
send group message recipients (#71)
723d35b
@milt
correct lesson session atype (#72)
e708dda
@davidpesce
Copy link
Collaborator

Hi Milt - first off, thank you for this enormous effort. It looks awesome! It's going to take me a bit of time to review, but I'm curious why the CI was removed from pull requests. Could you re-enable that in this PR?

@milt
Copy link
Contributor Author

milt commented Dec 16, 2024

Hi Milt - first off, thank you for this enormous effort. It looks awesome! It's going to take me a bit of time to review, but I'm curious why the CI was removed from pull requests. Could you re-enable that in this PR?

Hi David! As far as I could tell running CI on every push covers pull requests as well, but I'm happy to turn it back on.

milt added 3 commits December 16, 2024 10:31
@milt
reenable test on pr (#73)
e4849df
@milt
remove trailing spaces on scorm serialized event data (#74)
6ef0e99
@milt
PHP & Moodle Support Coverage (#75)
7de3e58 
* add php 8.0 to try and repro bug

* expand matrix

* try latest

* try 8.1 with latest

* try with declared prop

* update lib path

* use package on packagist

* try latest ll version

* correct xml

* nope, ours

* install plugins on 405 whoops

* combinatorial support explosion

* add exclusions of known incompatibilities
@milt
Copy link
Contributor Author

milt commented Dec 18, 2024 •
edited
Loading

We added PHP 8.3 compatibility and some other minor fixes. The support range is now PHP 8.1 to 8.3 and moodle 4.1 to 4.5.

davidpesce
davidpesce requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@davidpesce davidpesce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is overall awesome! Thank you so much for contributing!

Please take a look at the comments and let me know your thoughts.

This was referenced Jan 31, 2025
Closed
Closed
@milt milt mentioned this pull request Feb 6, 2025
Merged
@milt
Copy link
Contributor Author

milt commented Feb 7, 2025

@cliffcaseyyet noticed that there doesn't seem to be a way to set the statement $.context.platform from the UI. It currently derives platform (which we added) from the source_name config but I don't think that has UI and seems to be hardcoded in the config. I'm gonna make another PR on our side to add a new config for platform so you can, for instance, disambiguate between multiple peer instances of Moodle.

@milt milt mentioned this pull request Feb 7, 2025
Merged
milt added 2 commits February 7, 2025 13:52
@milt
LMS Object Cleanup (#77)
5328175 
* change default site object name to Moodle LMS

* use util for LMS site obj

* add LMS course to common data, breaking almost everything

* amend tests to account for hidden course ID 1

* semantically order all json keys since they got sorted anyhow
@milt
Create config for context platform (#78)
8e4db73
@milt
Copy link
Contributor Author

milt commented Feb 7, 2025

OK @davidpesce it should be all caught up with our changes now. Let us know if you find anything else.

@davidpesce davidpesce merged commit 0bb13cb into xAPI-vle:master Feb 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpesce davidpesce davidpesce approved these changes

+1 more reviewer

@cliffcaseyyet cliffcaseyyet cliffcaseyyet left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milt @davidpesce @cliffcaseyyet @invaliduser