Skip to content

Checkbox Table allows custom template for checkbox #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Checkbox Table allows custom template for checkbox #891

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a353b88
Checkbox Table allows custom template for checkbox
lucifilote Oct 14, 2021
2ba446e
Checkbox Table allows custom template for checkbox
lucifilote Oct 14, 2021
8c2b7e2
Merge remote-tracking branch 'origin/feature/checkbox-custom-template…
lucifilote Oct 14, 2021
f4a1f8d
Merge remote-tracking branch 'origin/feature/checkbox-custom-template…
lucifilote Oct 14, 2021
735ec62
Fixed slot rendering
lucifilote Oct 14, 2021
949fcd2
Bundle everything
lucifilote Oct 14, 2021
675a122
Delete vue-good-table.cjs.js
lucifilote Oct 15, 2021
bce842b
Revert "Delete vue-good-table.cjs.js"
lucifilote Oct 15, 2021
a77c470
Revert "Bundle everything"
lucifilote Oct 15, 2021
ebbf963
Revert "Merge remote-tracking branch 'origin/feature/checkbox-custom-…
lucifilote Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/components/Table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,15 @@
@click.stop="onCheckboxClicked(row, index, $event)"
class="vgt-checkbox-col"
>
<input
type="checkbox"
:disabled="row.vgtDisabled"
:checked="row.vgtSelected"
/>
<template v-if="hasCheckboxColumnTemplate">
<slot v-slot="props" name="table-checkbox-column" :row="row"></slot>
</template>
<input
v-else
type="checkbox"
:disabled="row.vgtDisabled"
:checked="row.vgtSelected"
/>
</th>
<td
@click="onCellClicked(row, column, index, $event)"
Expand Down Expand Up @@ -603,6 +607,13 @@ export default {
);
},

hasCheckboxColumnTemplate(){
return (
!!this.$slots['table-checkbox-column'] ||
!!this.$scopedSlots['table-checkbox-column']
);
},

showEmptySlot() {
if (!this.paginated.length) return true;

Expand Down Expand Up @@ -849,7 +860,7 @@ export default {
const column = this.getColumnForField(srt.field);
const xvalue = this.collect(xRow, srt.field);
const yvalue = this.collect(yRow, srt.field);

//* if a custom sort function has been provided we use that
const { sortFn } = column;
if (sortFn && typeof sortFn === 'function') {
Expand Down