-
Notifications
You must be signed in to change notification settings - Fork 9
Add a new SDN controller plugin #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is just the boiler plate for expected functions to show what is expected. We still need to:
|
97e4d95
to
ace8d98
Compare
Quick question: I suppose that at some point, for very useful plugins, we'd like to get them as "first class citizen" in XAPI, ie doing it directly in XAPI instead of relying on a plugin, right? (but plugins are convenient to start doing it to see if it's the right approach) |
Yes exactly. If we need to go further than applying openflow rules and validate the approach we will need to investigate more time and move the open vswitch things directly within xapi. |
Additionnally, we'll likely want XAPI to re-enable the openvswitch configuration automatically when it starts, without relying on XO to detect that it has to be done and to call the plugin, after each reboot of a host. So yes, there's an identified topic regarding the SDN controller and XAPI. |
510989f
to
29b5673
Compare
11b3d4e
to
bdb837f
Compare
@error_wrapped | ||
def add_rule(_session, args): | ||
_LOGGER.info("Calling add rule with args {}".format(args)) | ||
_LOGGER.info("Calling del rule with args {}".format(args)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"add" was correct IIUC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, there was some mistakes and I messed up when correcting them, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
8727564
to
6c04f2a
Compare
873f7ac
to
3dfc52c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the best person to review Python code, but I didn't notice anything bad jumping out at me.
182667d
to
16c23d6
Compare
89ac750
to
1ff6b14
Compare
This plugin allows to add and delete rules. A rule will be converted into one or more openflow rules. Once converted they are applied using ovs-vsctl command. To be able to validate the application of openflow rules the plugins allows to dump them. Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech> Signed-off-by: David Morel <david.morel@vates.tech>
d04eee7
to
836bb4b
Compare
This plugin allows to add, delete and dump openflow rules for a given bridge.