Skip to content

Update OAuth2 URL to X #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

osiastedian
Copy link

This should solve security issue when logging in with their X account.

Issue:
Even when user is logged out from Twitter when Oauth 2 Authorization URL is used the session still retains and work. In effect, it bypasses the security of being logged out.

Problem

  1. Say user logged into X and then "Sign in with X" on a Third Party App.
  2. And then they Log out their X account on x.com
  3. On the Third Party App, they try to Sign in with X using the OAuth2 Authorization Code Flow.

Result:

  1. Everything still works as if their session wasn't logged on step number 2.
  2. Third Party app will still be able to get access token

Solution

Change the authorization url to x.com so that when user logged out.
The session in their browser is also revoked/invalidated.

Result

Whenever user logged out and then they try to Sign in with X on a Third Party app.
They will have to sign in to X again.

This should solve security issue when logging in with their X account.

Issue:
Even when user is logged out from Twitter when Oauth 2  Authorization URL is  used the session still retains and work.
In effect, it bypasses the security of being logged out.

Signed-off-by: Ted Ian Osias <osiastedian@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jul 23, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants