XWIKI-23002: The attachment selector create should be a button instead of link #4589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of link * Updated the AttachmentSelector component to use a button instead of a link (kept backwards compatibility on JS). * Updated the custom styles of the user sheet to fit the new DOM * Updated the select and delete button selectors so that they work even when clicking the icon inside them (somehow they were bugged.)
…d of link * Reverted unwanted changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23002
Changes
Description
Screenshots & Video
None, no visual change.
Executed Tests
Manual tests
Build the changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-ui -Pquality, then ran the docker testsmvn clean install -f xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-test/xwiki-platform-attachment-test-dockersuccessfully.Expected merging strategy