Skip to content

Conversation

surli
Copy link
Member

@surli surli commented Oct 1, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-23546

Changes

Description

  • Provide grouping and ordering of various parameters

Clarifications

Screenshots & Video

Before

Capture d’écran du 2025-10-01 09-26-52 Capture d’écran du 2025-10-01 09-27-08 Capture d’écran du 2025-10-01 09-27-21

After

Capture d’écran du 2025-10-01 09-06-37 Capture d’écran du 2025-10-01 09-06-45 Capture d’écran du 2025-10-01 09-06-52 Capture d’écran du 2025-10-01 09-06-59 Capture d’écran du 2025-10-01 09-07-10

Executed Tests

mvn clean install -Pquality,integration-tests,docker on module xwiki-platform-index-tree. Should be enough: we don't have any integration tests manipulating the macro config UI.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None

  * Provide grouping and ordering of various parameters
@surli surli marked this pull request as ready for review October 1, 2025 07:31
@surli surli self-assigned this Oct 1, 2025
@surli surli requested review from mflorea and tkrieck October 1, 2025 07:31
@tkrieck
Copy link
Contributor

tkrieck commented Oct 3, 2025

Some things that could be reworked if possible:

  • I would order the tabs by order of complexity.
    • Display Options (common quick customizations)
    • Elements to Show (same, a bit more expanded)
    • Filters
    • Optional Parameters
  • The hints that are over explanatory. I guess this is outside the scope of this PR

Otherwise, seems fine the way it is.

@mflorea
Copy link
Member

mflorea commented Oct 6, 2025

The hints that are over explanatory. I guess this is outside the scope of this PR

I agree that some hints are too long and can be simplified (no more than 2 lines of text ideally).

Furthermore, just by looking at the screenshots, I would:

  • move the "Exclusions" parameter to the "Filters" group
  • move the "Expand to level" to the "Display options" group (maybe also the "Sort pages by", but I'm not sure)

Copy link
Member

@mflorea mflorea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only comment is the one posted above.

@surli
Copy link
Member Author

surli commented Oct 6, 2025

I would order the tabs by order of complexity.

Thanks for the review. I would keep displaying "Optional parameters" first: IMO the first parameters (root / open to / limit / sort by) are probably the most used parameters and that's why I decided to fix their order. Unless I can find a common group name for them. I will check for ordering of the other tabs.

move the "Exclusions" parameter to the "Filters" group
move the "Expand to level" to the "Display options" group (maybe also the "Sort pages by", but I'm not sure)

OK I'll do that for Exclusions / Expand to. For sort I'd keep it in first tab to be quickly available.

The hints that are over explanatory. I guess this is outside the scope of this PR

Yeah they probably need some work, I'll see if I can improve them a bit, otherwise it could be done later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants