Fix trace_with deprecation warnings
#9
Merged
+201
−496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Envek is there a way to move this forward toward a release somehow? |
Envek
requested changes
Nov 20, 2025
Member
There was a problem hiding this comment.
@loadkpi, thank you very much for your pull request and sorry for the long wait!
I think that there is no much value in keeping the old implementation at all. Let's drop all legacy stuff and version checks and instead bump minimum graphql-ruby version requirement to 2.0 (that's where current Tracing API appeared if I'm right)
For yabeda-graphql users it should be completely unnoticeable as all changes are hidden behind use Yabeda::GraphQL hook.
Envek
approved these changes
Dec 3, 2025
Envek
changed the title
trace_with deprecation warningstrace_with deprecation warnings
Member
|
Released in 0.3.0 Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-ruby.Keep the backward compability@Envek there's some code duplication between the new and legacy implementations. What is you opinion: should I DRY this up by extracting shared methods, or keep the implementations separate for simplicity?