Add animationController and appearanceController to give better control over badge's animation #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… control over badge's animation
wamynobe
changed the title
|
There is a problem that the AnimationController will call dispose() more than once. |
…roller after they were created
wamynobe
changed the title
|
@yadaniyil Can you take a look on this please? |
|
@M-ixai-L Can you take a look on this pls? |
|
@M-ixai-L There are some cases that I want the badge to animate even if it did not change the value. In these cases I think animationController.forward will be fine. So getting the animation controller instance from badge class is a simple way to archive that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
#127
Resolve issue #???
#127
Connected to #???
#127
Testing and Review Notes
I am not sure but I ran all current test cases and they all passed. Because this pr will not cause any breaking changes so I think It will be fine 😃
Screenshots or Videos
To Do