Skip to content

Conversation

@dorooleg
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@dorooleg dorooleg requested a review from Vladilen October 30, 2025 22:29
@dorooleg dorooleg requested a review from a team as a code owner October 30, 2025 22:29
@dorooleg dorooleg requested a review from Copilot October 30, 2025 22:31
@github-actions
Copy link

🟢 2025-10-30 22:32:28 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 22:32:47 UTC Pre-commit check linux-x86_64-release-asan for dc7ef18 has started.
2025-10-30 22:32:57 UTC Artifacts will be uploaded here
2025-10-30 22:34:24 UTC ya make is running...
🟡 2025-10-31 00:32:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15287 14848 0 166 249 24

🟢 2025-10-31 00:32:30 UTC Build successful.
🟢 2025-10-31 00:32:54 UTC ydbd size 3.8 GiB changed* by -944 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 66a9bb5 merge: dc7ef18 diff diff %
ydbd size 4 062 452 776 Bytes 4 062 451 832 Bytes -944 Bytes -0.000%
ydbd stripped size 1 508 019 736 Bytes 1 508 019 416 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 22:32:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc7ef18 has started.
2025-10-30 22:33:01 UTC Artifacts will be uploaded here
2025-10-30 22:34:29 UTC ya make is running...
🟢 2025-10-30 23:58:48 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31417 30003 0 0 1385 29

🟢 2025-10-30 23:58:56 UTC Build successful.
🟢 2025-10-30 23:59:09 UTC ydbd size 2.3 GiB changed* by -544 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 66a9bb5 merge: dc7ef18 diff diff %
ydbd size 2 426 223 416 Bytes 2 426 222 872 Bytes -544 Bytes -0.000%
ydbd stripped size 515 659 496 Bytes 515 659 432 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused code from the TInFlightReadsTracker::AddToInFlightRequest method. The change eliminates a conditional block that attempted to cast readMetaBase to a specific type but performed no operations with the result.

  • Removed dead code that cast readMetaBase to TReadMetadata without using the result

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dorooleg dorooleg enabled auto-merge (squash) October 31, 2025 06:43
@dorooleg dorooleg merged commit ef0097c into ydb-platform:main Oct 31, 2025
18 checks passed
@dorooleg dorooleg deleted the small_cleanup branch October 31, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants