Framework

[LebedevOleg1]

Changelog entry

...

Changelog category

• Not for changelog (changelog entry is not required)

Description for reviewers

...

[github-actions]

⚪ 2025-10-31 00:19:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3cf7f68 has started.
⚪ 2025-10-31 00:20:11 UTC Artifacts will be uploaded here
⚪ 2025-10-31 00:22:00 UTC ya make is running...
🟢 2025-10-31 00:24:35 UTC Tests successful.

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
13	13	0	0	0	0

🟢 2025-10-31 00:24:38 UTC Build successful.
🟢 2025-10-31 00:24:49 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: 49e024a	merge: 3cf7f68	diff	diff %
ydbd size	2 426 223 416 Bytes	2 426 223 416 Bytes	0 Bytes	0.000%
ydbd stripped size	515 659 496 Bytes	515 659 496 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2025-10-31 00:21:18 UTC Pre-commit check linux-x86_64-release-asan for 3cf7f68 has started.
⚪ 2025-10-31 00:21:43 UTC Artifacts will be uploaded here
⚪ 2025-10-31 00:23:03 UTC ya make is running...
🟢 2025-10-31 00:24:21 UTC Tests successful.

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
3	3	0	0	0	0

🟢 2025-10-31 00:24:24 UTC Build successful.
🟢 2025-10-31 00:24:38 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: 66a9bb5	merge: 3cf7f68	diff	diff %
ydbd size	4 062 452 776 Bytes	4 062 452 680 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 508 019 736 Bytes	1 508 019 672 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

🟢 2025-10-31 00:24:07 UTC The validation of the Pull Request description is successful.

[github-actions]

⚪ 2025-10-31 09:11:53 UTC Pre-commit check linux-x86_64-release-asan for 9a60936 has started.
⚪ 2025-10-31 09:12:10 UTC Artifacts will be uploaded here
⚪ 2025-10-31 09:13:27 UTC ya make is running...
🟢 2025-10-31 09:15:02 UTC Tests successful.

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
3	3	0	0	0	0

🟢 2025-10-31 09:15:05 UTC Build successful.
🟢 2025-10-31 09:15:19 UTC ydbd size 3.8 GiB changed* by +54.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: e300863	merge: 9a60936	diff	diff %
ydbd size	4 063 259 016 Bytes	4 063 314 312 Bytes	+54.0 KiB	+0.001%
ydbd stripped size	1 508 282 968 Bytes	1 508 297 592 Bytes	+14.3 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2025-10-31 09:12:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9a60936 has started.
⚪ 2025-10-31 09:12:59 UTC Artifacts will be uploaded here
⚪ 2025-10-31 09:14:21 UTC ya make is running...
🟢 2025-10-31 09:17:24 UTC Tests successful.

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
17	17	0	0	0	0

🟢 2025-10-31 09:17:26 UTC Build successful.
🟢 2025-10-31 09:17:37 UTC ydbd size 2.3 GiB changed* by +32.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: e300863	merge: 9a60936	diff	diff %
ydbd size	2 426 524 152 Bytes	2 426 557 040 Bytes	+32.1 KiB	+0.001%
ydbd stripped size	515 709 512 Bytes	515 713 416 Bytes	+3.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[Enjection]

I like it. There are couple little improvements but I believe we will address them later.

[Enjection]

silent failure is not expected here:

1. log error
2. rename method to _try_drop_table or something like this, to express "best effort" nature of this method

[Enjection]

complex search for table can confuse two different tables with same name, but in different dirs, consider documenting this behavior

[Enjection]

Consider explicit type instead of dict. Make all builders consistent (e.g. Tuple[bool, Restore], Tuple[bool, SnapshotName])

[Enjection]

or maybe

@dataclass
class BackupResult:
    success: bool
    snapshot_name: str
    
@dataclass  
class RestoreResult:
    success: bool
    data_verified: bool
    schema_verified: bool
    acl_verified: bool

[Enjection]

You already inherited from str, I guess you don't need this override