Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Aug 7, 2025

This PR adds support for specifying custom source directory paths via function parameters instead of deriving them automatically from the app name, addressing the feature request in issue #13.

Changes Made

Added new function overloads to the main ExIntegrationCoveralls module:

New Functions for get_app_total_cov:

  • get_app_total_cov/2 - accepts custom run-time source directory path
  • get_app_total_cov/3 - accepts both custom compile-time and run-time source directory paths

New Functions for post_app_cov_to_ci:

  • post_app_cov_to_ci/4 - accepts custom run-time source directory path
  • post_app_cov_to_ci/5 - accepts both custom compile-time and run-time source directory paths

Usage Examples

# Original functionality (unchanged for backward compatibility)
ExIntegrationCoveralls.get_app_total_cov("my_app")
ExIntegrationCoveralls.post_app_cov_to_ci(url, extends, "my_app")

# NEW: With custom run-time source directory path
ExIntegrationCoveralls.get_app_total_cov("my_app", "/custom/source/path")
ExIntegrationCoveralls.post_app_cov_to_ci(url, extends, "my_app", "/custom/source/path")

# NEW: With both custom compile-time and run-time source directory paths
ExIntegrationCoveralls.get_app_total_cov("my_app", "/compile/time/path", "/run/time/path")
ExIntegrationCoveralls.post_app_cov_to_ci(url, extends, "my_app", "/compile/time/path", "/run/time/path")

Benefits

  • Flexible: Users can now specify source paths via HTTP request parameters or function calls
  • Backward Compatible: All existing functionality remains unchanged
  • Well-Tested: Comprehensive test coverage following existing patterns
  • Documented: Updated README with usage examples and benefits

This is particularly useful when:

  • Source code is located in non-standard locations
  • Analyzing coverage for specific subsets of the codebase
  • Working with different paths for compile-time vs run-time environments

Fixes #13.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copy link
Author

Copilot AI commented Aug 7, 2025

@yeshan333 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI and others added 2 commits August 7, 2025 16:00
Co-authored-by: yeshan333 <39296814+yeshan333@users.noreply.github.com>
Co-authored-by: yeshan333 <39296814+yeshan333@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] 【feat】Support for specifying source directory path feat: Add support for custom source directory paths via function overloads Aug 7, 2025
@Copilot Copilot AI requested a review from yeshan333 August 7, 2025 16:07
Copilot finished work on behalf of yeshan333 August 7, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【feat】Support for specifying source directory path
2 participants