Fix control bitmap bounds with DWM enabled #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmy D'Anello <emmy.danello@sncf.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #307 introduced a regression while creating a Bitmap object from a Control. This PR partially resolved #308, but only for a window control. When transforming an inner control into a Bitmap, the current code is computing
pRectwhich is the bounding rectangle of the handle and add its coordinates to the requested rectangle's ones.I had an issue because the bounding rectangle of my window start from
(-8, -8)and goes to(1928, 1088), and all my screenshots were dephased from 8 pixels to the top and to the left. Replacing theses boundings with these given byDwmGetWindowExtendFrameBoundssolves the issue, as in other parts of the file.