Fix nullable transformable properties handling #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #14
Issue Description
There was an issue with transforming nullable transformable properties (like DTO objects) when
nullvalues were provided. Instead of preserving thenullvalue, the system was incorrectly creating an empty instance of the class.How to reproduce
Expected behavior
The
$purchaseDTO->discountproperty should benullsince we providednullin the input data and the property is nullable (?DiscountDTO).Actual behavior
The system was creating an empty DiscountDTO object:
Fix
The issue was in the
PropertyTypeFactory::create()method, where the wrong parameter was being passed to theTransformableTypeconstructor. The method was passing the$isScalarflag instead of the$isNullableflag, causing the nullable information to be lost during transformation.This PR fixes the issue by passing the correct
$isNullableparameter to ensure that nullable properties remainnullwhennullvalues are provided.Tests
Added a test condition to
ValueCastingTestand new test cases toClassTransformerFromArrayTestthat verify:nullwhennullis provided