Skip to content

feat(mpc-party): Improved RDS configuration by adding variables and removing unnecessary variables. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2025
Merged

feat(mpc-party): Improved RDS configuration by adding variables and removing unnecessary variables. #53

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a037a40
feat(mpc-party): Improved RDS configuration by adding variables and r…
43z708 Sep 19, 2025
61e4df4
Formatted
43z708 Sep 19, 2025
8ea989a
Merge branch 'main' into fix/example-variables
43z708 Sep 23, 2025
01b2424
Remove nodegroup_source_security_group_ids and rds_prefix
43z708 Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/mpc-party/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ module "mpc_party" {

kms_image_attestation_sha = var.kms_image_attestation_sha
kms_deletion_window_in_days = var.kms_deletion_window_in_days
nodegroup_source_security_group_ids = var.nodegroup_source_security_group_ids
nodegroup_additional_security_group_ids = var.nodegroup_additional_security_group_ids
nodegroup_enable_ssm_managed_instance = var.nodegroup_enable_ssm_managed_instance
nodegroup_use_latest_ami_release_version = var.nodegroup_use_latest_ami_release_version
Expand All @@ -79,6 +80,7 @@ module "mpc_party" {
# RDS Configuration
enable_rds = var.enable_rds
rds_db_name = var.rds_db_name
rds_prefix = var.rds_prefix
rds_create_monitoring_role = var.rds_create_monitoring_role
rds_manage_master_user_password = var.rds_manage_master_user_password
rds_username = var.rds_username
Expand All @@ -103,7 +105,6 @@ module "mpc_party" {
rds_k8s_secret_namespace = var.rds_k8s_secret_namespace
rds_allowed_cidr_blocks = var.rds_allowed_cidr_blocks
rds_vpc_id = var.rds_vpc_id
rds_subnet_ids = var.rds_subnet_ids
rds_deletion_protection = var.rds_deletion_protection

# Tagging
Expand Down
1 change: 1 addition & 0 deletions examples/mpc-party/terraform.tfvars.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ aws_region = "eu-west-1"
enable_region_validation = false

# MPC Party Configuration
party_id = 1
party_name = "mpc-party-2"
environment = "dev"

Expand Down
12 changes: 0 additions & 12 deletions examples/mpc-party/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,6 @@ variable "kubeconfig_context" {
default = null
}

variable "eks_cluster_name" {
description = "EKS cluster name for automatic token authentication (optional, used for exec auth)"
type = string
default = null
}

# Tagging
variable "additional_tags" {
description = "Additional tags to apply to all resources"
Expand Down Expand Up @@ -446,12 +440,6 @@ variable "rds_vpc_id" {
default = null
}

variable "rds_subnet_ids" {
description = "Subnet IDs for the RDS database"
type = list(string)
default = []
}

variable "rds_create_monitoring_role" {
description = "Whether to create the RDS monitoring role"
type = bool
Expand Down