Print labels with their colors on lab label list #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes the label.color hex and converts it to color in HexToRGB in utils, then uses rgbterm lib to convert rgb to terminal color. Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
zampierilucas
force-pushed
the
label_color
branch
from
51da8c3 to
83be724
Compare
|
This is what the labels look like with the change. |
|
as a go noob , I was not able to run the PR from the folder via |
|
I like this change but I think it should be optional. @zampierilucas I think you should add a config option for this to enable the colors. That way users can set it in their lab.toml and not worry about it. |
Label colored printing can be enabled by the --color param, or by using the config file. Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
|
@prarit I've updated my mr with you suggestion. |
title Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
bmeneg
approved these changes
Feb 26, 2024
|
was the CI failure linked to this PR ? else maybe it's mergeable ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the
label.Colorhex and converts it to color in HexToRGB in utils, then uses is to set the background color.Closes: #887