feat: change dependency for process_cwd
#1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsnif
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
@jaeheonji - this looks good! I'm not sure what caused the behaviour change with the tests... but if it passes consistently now, it's fine. I think it's only about which pane is focused on attach, which doesn't make a big difference. You can merge this whenever you feel ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue related the
darwin-libprocdependency.The darwin-libproc library has not been updated for a long time, including dependency issues.
(reference: heim-rs/darwin-libproc#3 and current problem is similar to this: #953 (comment))
So this PR simplifies the
get_cwdfunction while using the new library sysinfo.EDIT: During the E2E test, an error related to
detach_and_attach_session()continued to occur, so I looked at the snapshot data and the actual app operation. The operation and the snapshot data match, but the test case seems to be inconsistent, so I modified it. But modifying test cases should always be done with caution. So, please let me know if this fix is wrong.